Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] support inspecting subjects in stream via StreamInfo - ADR issue 91 #293

Merged
merged 2 commits into from
May 11, 2022
Merged

[FEAT] support inspecting subjects in stream via StreamInfo - ADR issue 91 #293

merged 2 commits into from
May 11, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented May 11, 2022

No description provided.

@aricart
Copy link
Member Author

aricart commented May 11, 2022

FIX #292

1 similar comment
@aricart
Copy link
Member Author

aricart commented May 11, 2022

FIX #292

kozlovic
kozlovic approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would expand on the test, at very least check that without filter field, si.state.subjects is not set.

tests/jsm_test.ts Outdated Show resolved Hide resolved
@aricart aricart temporarily deployed to CI May 11, 2022 21:04 Inactive
kozlovic
kozlovic approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I suggested more restrictive than ">" as a replacement, not addition, but that's fine).

@aricart aricart merged commit 8ac0687 into main May 11, 2022
@aricart aricart deleted the adr-issue-91 branch August 22, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees

@kozlovic kozlovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aricart @kozlovic