[FEAT] implements the ability in KV to request a specific revision for a key #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
requested changes
May 16, 2022
| const sm = await this.jsm.streams.getMessage(this.bucketName(), { | ||
| last_by_subj: this.fullKeyName(ek), | ||
| }); | ||
| const sm = await this.jsm.streams.getMessage(this.bucketName(), arg); |
There was a problem hiding this comment.
There is a nuance in the Go client: when asking for a revision (sequence number), it is possible that a message is found at that sequence, but that does not mean that it will match the subject (the key). So if you had "A"/seq 1, "B"/seq 2 and you ask Get("A", 2), a message will be returned by the low level "getMessage(2)", but that does not match the key/subject "A", so you should return "key not found" in that case.
| await b.put("A", sc.encode("d")); | ||
| await check("d"); | ||
| await check(null, 1); | ||
|
|
There was a problem hiding this comment.
Should extend the test to demonstrate the issue I was referring to. Do a "put("B", someValue)" and then a "get("A", rev==5)", and you should have a failure (and not whatever value was stored in "B").
…nce (new feature), that the key matched. If not, null is returned as the sequence is not referencing the expected key. [FIX] conversion from stored message captured the key as provided by the client, and returned an entry with the said key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #301