[FIX] change transport.send() to not return a promise #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that a timeout is not a number.
…id, and allow dequeue to reject it, as that is the only place where we wait for the socket write to complete, an error there is only logged if debug is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another unhandled promise on a K8S environment during the connect/ping exchange an EPIPE was getting generated because of aggressive throttling on resource limits (100 millis of a CPU given to the process).
Verified the change with the help of @arjenvdhave who was kind enough to test and reproduce in his environment.
See #289 (comment)