Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] objectstore (wip) #339

Merged
merged 10 commits into from
Aug 10, 2022
Merged

[FEAT] objectstore (wip) #339

merged 10 commits into from
Aug 10, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented Aug 3, 2022

No description provided.

@jmordica
Copy link

jmordica commented Aug 4, 2022

Woohoo! Excited about this one 🎉

@aricart aricart temporarily deployed to CI August 4, 2022 21:32 Inactive
@aricart aricart temporarily deployed to CI August 5, 2022 20:49 Inactive
@aricart aricart temporarily deployed to CI August 8, 2022 16:19 Inactive
@aricart aricart temporarily deployed to CI August 8, 2022 21:07 Inactive
@aricart
[FIX] fixes related to cross-client compatibility hash-padding, mtime…
7077e0c 
… format

[CHANGE] remove beta from kv notice, targetted object store instead.
[FIX] name encoding was only replacing first char not sequences
@aricart aricart temporarily deployed to CI August 9, 2022 21:22 Inactive
@aricart aricart marked this pull request as ready for review August 9, 2022 21:22
@aricart aricart requested a review from kozlovic August 9, 2022 21:22
kozlovic
kozlovic approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/objectstore_test.ts Show resolved Hide resolved
@aricart aricart temporarily deployed to CI August 10, 2022 14:02 Inactive
kozlovic
kozlovic approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart temporarily deployed to CI August 10, 2022 14:24 Inactive
@aricart aricart temporarily deployed to CI August 10, 2022 16:14 Inactive
@aricart
[FIX] simplified the nuid "shim" for getRandomValues
ecceb6a 
[FIX] put an assertion for crypto.subtle on the objectstore create, as this is required
@aricart aricart temporarily deployed to CI August 10, 2022 19:51 Inactive
@aricart aricart requested a review from kozlovic August 10, 2022 20:05
kozlovic
kozlovic approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit e07ec14 into main Aug 10, 2022
@aricart aricart deleted the feat-object-store branch August 10, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aricart @jmordica @kozlovic