KV mirror #391
Merged
KV mirror #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
kozlovic
reviewed
Oct 28, 2022
| @@ -83,6 +109,9 @@ export class StreamAPIImpl extends BaseApiClient implements StreamAPI { | |||
| validateStreamName(name); | |||
| const old = await this.info(name); | |||
| const update = Object.assign(old.config, cfg); | |||
| update.mirror = convertStreamSourceDomain(update.mirror); | |||
There was a problem hiding this comment.
Not sure updating a stream and changing the mirror/source actually works (in that I don't think the server supports that), so maybe the reason why it is only on "AddStream" in the go client?
There was a problem hiding this comment.
it should be a noop regardless - because it has to have "domain" set which won't be, so it is ignored. I just wanted to trap it for uniformity in case it updates later.
… to, to prevent a lookup of a stream by subject. [FEAT] added support for KVs to be accessed from a mirror
|
@kozlovic I added the additional changes required by the client to support history, watch, keys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.