Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PullConsumerMessagesImpl not respecting inboxPrefix #580

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix PullConsumerMessagesImpl not respecting inboxPrefix #580

merged 1 commit into from
Aug 28, 2023

Conversation

oscarwcl
Copy link
Contributor

No description provided.

aricart
aricart approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 5cab8ac into nats-io:main Aug 28, 2023
@aricart
Copy link
Member

aricart commented Aug 28, 2023

@oscarwcl thank for the PR.

aricart added a commit that referenced this pull request Aug 28, 2023
@aricart
[TEST] Added tests for #580
1d168e3
aricart added a commit that referenced this pull request Aug 28, 2023
@aricart
Merge pull request #581 from nats-io/consumer-inbox-tests
b8e48ee 
[TEST] Added tests for #580
@oscarwcl oscarwcl deleted the js-consumer-inbox-prefix branch August 30, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarwcl @aricart