Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] disable async trace extra information #622

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[FEAT] disable async trace extra information #622

merged 2 commits into from
Oct 26, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Oct 24, 2023

This PR increases the performance of request reply by optionally eliminating the capturing of a trace which is used to provide context to failed requests.

To make use of this performance enhancement, specify the noAsyncTraces connection option with true.

This PR is based on #613
Thanks you @theovandrdonk for the initial contribution.

@aricart aricart temporarily deployed to CI October 24, 2023 14:00 — with GitHub Actions Inactive
@aricart aricart marked this pull request as ready for review October 24, 2023 15:15
@aricart aricart mentioned this pull request Oct 24, 2023
@aricart aricart requested a review from Jarema October 25, 2023 21:21
@aricart
Copy link
Member Author

aricart commented Oct 26, 2023

Fixes #614

Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 41e3118 into main Oct 26, 2023
3 checks passed
@aricart aricart deleted the stacks branch October 26, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants