Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] added reason to JsMsg#term - this feature requires 2.11.0 #630

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[FEAT] added reason to JsMsg#term - this feature requires 2.11.0 #630

merged 1 commit into from
Nov 2, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Oct 30, 2023

[TEST] moved util to different test file otherwise some tests run multiple times

@aricart
[FEAT] added reason to JsMsg#term - this feature requires 2.11.0
6a4069c 
[TEST] moved util to different test file otherwise some tests run multiple times
@aricart aricart temporarily deployed to CI October 30, 2023 21:46 — with GitHub Actions Inactive
@aricart aricart requested a review from Jarema November 2, 2023 02:08
scottf
scottf approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit 4225414 into main Nov 2, 2023
3 checks passed
@aricart aricart deleted the term-reason branch November 2, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottf scottf scottf approved these changes

@Jarema Jarema Awaiting requested review from Jarema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aricart @scottf