Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow internal kv watch consumer to use filtered consumer api #662

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Mar 12, 2024

[FIX] changed KV ordered consumers created by watch, to set name if supported by the server. This enables the client to be able to use the newer consumer APIs which can then be clamped down with permissions on filter

[FIX] removed unused JSM reference in the Views implementation

… supported by the server. This enables the client to be able to use the newer consumer APIs which can then be clamped down with permissions on filter

[FIX] removed unused JSM reference in the Views implementation
const iter = await kv.watch({ key: "a.>" });

const m = await sub.next();
console.log(m?.subject);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramonberrutti thanks Ramon!!

Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit d0ba08f into main Mar 13, 2024
3 checks passed
@aricart aricart deleted the kv-filtered-watcher branch March 13, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants