[IMPROVED] Add extra option to OrderedConsumerConfig #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mwain, thank you for the contribution! While I agree that metadata may be useful for ordered consumers, I'm not sure about |
|
Hi @piotrpio, thanks for the review. We used it to cap the bytes being buffered. TBH i didn't see the Would you like me to update this to remove |
|
@mwain That would be great, thanks! |
Signed-off-by: Michael Wain <michael@sanity.io>
mwain
force-pushed
the
feat/add-cfg-opts-to-ordered
branch
from
ca18849 to
7718564
Compare
mwain
changed the title
|
@piotrpio Updated |
piotrpio
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Id like to set these options for ordered consumers.