[FIXED] Possible panic on WaitGroup.Wait() #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been 2 reports in the last 10 months of this happening once each. We have not been able to reproduce the issue. However, this code change should eliminate the possibility of code going into a Wait() while in parallel doing an Add() (for the same group). There is no new test since we have multiple tests that check for reconnect and we have not been able to reproduce. A long running test causing 100,000 server restarts at randome interval has been running on *original code* without producing the panic. Attempt to resolve #192
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been 2 reports in the last 10 months of this happening
once each. We have not been able to reproduce the issue. However,
this code change should eliminate the possibility of code going
into a Wait() while in parallel doing an Add() (for the same group).
There is no new test since we have multiple tests that check for
reconnect and we have not been able to reproduce. A long running
test causing 100,000 server restarts at random interval has been
running on original code without producing the panic.
Attempt to resolve #192