Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Direct Message Subject Header May Contain Multiple Subjects #1016

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[FIX] Direct Message Subject Header May Contain Multiple Subjects #1016

merged 4 commits into from
Oct 19, 2023

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Oct 18, 2023 •
edited
Loading

For republished messages, the Nats-Subject header may contain multiple subjects. Direct message used to take the first subject, but is changed to take the last subject

aricart
aricart approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit 61257e4 into main Oct 19, 2023
2 checks passed
@scottf scottf deleted the direct-message-last-subject branch October 19, 2023 00:24
@scottf scottf changed the title Direct Message Subject Header May Contain Multiple Subjects [FIX] Direct Message Subject Header May Contain Multiple Subjects Oct 20, 2023
@scottf scottf mentioned this pull request Nov 3, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aricart aricart aricart approved these changes

@Jarema Jarema Awaiting requested review from Jarema

@piotrpio piotrpio Awaiting requested review from piotrpio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @aricart