Extract json, nkey and jwt utils to libraries #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
commented
Jan 30, 2024
| @@ -36,7 +36,10 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation 'net.i2p.crypto:eddsa:0.3.0' | |||
There was a problem hiding this comment.
crypto is needed by the nkeys library, so not directly needed here
scottf
commented
Jan 30, 2024
| @@ -109,9 +107,9 @@ public static String endFormattedJson(StringBuilder sb) { | |||
| * @param json raw json | |||
| */ | |||
| public static void addRawJson(StringBuilder sb, String fname, String json) { | |||
| if (json != null && json.length() > 0) { | |||
| if (json != null && !json.isEmpty()) { | |||
There was a problem hiding this comment.
IntelliJ won't stop harassing me!
MauriceVanVeen
approved these changes
Jan 31, 2024
scottf
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nkey and jwt code were extracted from the library to their own to make the jwt code available without the client. The json code was extracted because the jwt code depends on it.
In all cases, no public api was changed. This was accomplished in 2 ways.
If the developer uses gradle or maven, extracted dependencies will automatically be for runtime use, but extra dependency management may be required if those extract libraries are used for compilation of developer code.
Since no api has changed we will not major version, but we are bumping the minor version to 18 for visibility.