Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Poison pill comparison was failing #1162

Merged
merged 3 commits into from
Jun 21, 2024
Merged

[Bug] Poison pill comparison was failing #1162

merged 3 commits into from
Jun 21, 2024

Conversation

scottf
Copy link
Contributor

@scottf scottf commented Jun 19, 2024

No description provided.

@scottf scottf requested a review from MauriceVanVeen June 19, 2024 20:24
MauriceVanVeen
MauriceVanVeen approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, but LGTM!

src/main/java/io/nats/client/impl/MessageQueue.java Outdated Show resolved Hide resolved
@scottf scottf requested a review from MauriceVanVeen June 20, 2024 20:12
MauriceVanVeen
MauriceVanVeen approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Like the decrease of indents in connectImpl, etc. 👍

@scottf
Copy link
Contributor Author

scottf commented Jun 20, 2024

@MauriceVanVeen can you recheck this change: https://github.com/nats-io/nats.java/pull/1162/files#diff-bbcf614ee7ee4ccd15b22d1f95fa40e4e642098386b6d1d14127dab5968d89feL377

@scottf scottf merged commit 8e20807 into main Jun 21, 2024
2 checks passed
@scottf scottf deleted the poison-pill-comparison branch June 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottf @MauriceVanVeen