Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended (new) APIs and more example code #1191

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Conversation

roeschter
Copy link
Collaborator

This is a test edit to verify style guides.

Starting to make good on my promise to improve the documentation.

Purpose:

  1. Point users to the recommended (new) way of using Jetstream
  2. Add more example code snipplets
  3. Make sure such guidelines and code snipplet appear as early as possible in the developers journey. In this case on the Connection class.
  4. More detailed examples would then be in ConsumerContext and StreamContext

@roeschter roeschter changed the title Recommend API and example code Recommended (new) APIs and more example code Jul 31, 2024
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roeschter
Copy link
Collaborator Author

Will fix Javadoc errors

@roeschter
Copy link
Collaborator Author

Fixed various Javadoc errors and warning. Added links to overview.html
Javadoc processes without wanrings
Done editing - will continue on another branch.

@scottf
Copy link
Contributor

scottf commented Aug 1, 2024

@roeschter There is a test failing, but I fixed and merged it a few days ago. Can you update your branch

src/main/java/io/nats/client/impl/Headers.java Outdated Show resolved Hide resolved
src/main/java/io/nats/client/impl/Headers.java Outdated Show resolved Hide resolved
src/main/java/io/nats/client/impl/Headers.java Outdated Show resolved Hide resolved
src/main/java/io/nats/client/impl/Headers.java Outdated Show resolved Hide resolved
src/main/java/io/nats/client/impl/Headers.java Outdated Show resolved Hide resolved
src/main/javadoc/overview.html Show resolved Hide resolved
@roeschter
Copy link
Collaborator Author

Cleaned up

@scottf scottf merged commit c0dcf12 into nats-io:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants