Catch errors in Dispatchers and log #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
requested changes
Aug 12, 2024
| } catch (Error err) { | ||
| // Make sure we log, so we don't silently exit our loop. | ||
| // https://github.com/nats-io/nats.java/issues/1198 | ||
| err.printStackTrace(); |
There was a problem hiding this comment.
what about
connection.processException(new Exception(err));
There was a problem hiding this comment.
I'm leaning more toward logging and failing, than still processing the error and continuing on.
I'm thinking an Error indicates something that's not recoverable, versus an Exception being something that's just unexpected or can be retried.
In the case that the Error is not recoverable, there is probably not much we can do to keep running anyway. Might as well log and quit.
There was a problem hiding this comment.
Changed to indeed process as exception and continue.
MauriceVanVeen
changed the title
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
fix/catch-error-in-dispatchers
branch
from
85a9dd8 to
0714961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1198
We could handle the
Errorin theErrorListenerjust like theExceptionis handled.But, an
Erroris likely to not be recoverable so probably stopping the dispatcher is the way to go? Just need to log that it happened.