Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During forceReconnect, ensure reader/writer is stopped before continuing #1203

Merged
merged 2 commits into from
Aug 13, 2024
Merged

During forceReconnect, ensure reader/writer is stopped before continuing #1203

merged 2 commits into from
Aug 13, 2024

Conversation

MauriceVanVeen
Copy link
Member

@MauriceVanVeen MauriceVanVeen commented Aug 13, 2024 •
edited by scottf
Loading

This fixes an issue where on force reconnect the original threads of the reader and writer become parked, making them unavailable for other uses, eventually freezing the client.

@MauriceVanVeen
During forceReconnect, ensure reader/writer is stopped before continuing
866ad8f 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
scottf
scottf approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZEGU

@MauriceVanVeen
Before closing socket in handleCommunicationIssue, ensure we're not…
4e8ac2b 
… already trying to connect

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen
Copy link
Member Author

Made another fix, since closeSocket could be called simultaneously from different threads. This was due to handleCommunicationIssue calling into this, without checking if we were already tryingToConnect in another thread.

@scottf scottf merged commit ddb4b78 into main Aug 13, 2024
2 of 3 checks passed
@scottf scottf deleted the fix/reconnect-ensure-io-is-stopped branch August 13, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottf scottf scottf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauriceVanVeen @scottf