[Fixed] close connection when flush fails during drain. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixeds #324 Signed-off-by: Matthias Hanel <mh@synadia.com>
ColinSullivan1
approved these changes
Aug 5, 2020
ColinSullivan1
requested changes
Aug 5, 2020
There was a problem hiding this comment.
Thanks for looking into this.
Can you check the failing test?
io.nats.client.impl.DrainTests > testLeftOverTimer FAILED
java.lang.AssertionError: Timer gone
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at io.nats.client.impl.DrainTests.testLeftOverTimer(DrainTests.java:66)
There where more than 1 timer with the same name when running in gradlew
|
@ColinSullivan1 had to change the unit test. running in gradlew there where more than one timer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixeds #324
Signed-off-by: Matthias Hanel mh@synadia.com