Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for timeout propagation in async requests #615

Closed
wants to merge 1 commit into from
Closed

Support for timeout propagation in async requests #615

wants to merge 1 commit into from

Conversation

dxxyy
Copy link
Contributor

@dxxyy dxxyy commented Mar 18, 2022

Give the possibility to clients to specify a timeout while performing async requests.
More details in #616

Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Need to make sure the commit is verified.

@scottf
Copy link
Contributor

scottf commented Mar 18, 2022

@dxxyy This PR is conditionally approved. If you want to be kept as the contributor, you must verify your commit. Here is a doc to get you started: https://docs.github.com/en/authentication/managing-commit-signature-verification

@dxxyy
Copy link
Contributor Author

dxxyy commented Mar 20, 2022

@dxxyy This PR is conditionally approved. If you want to be kept as the contributor, you must verify your commit. Here is a doc to get you started: https://docs.github.com/en/authentication/managing-commit-signature-verification

Thanks! Commit now verified.

@scottf
Copy link
Contributor

scottf commented Mar 21, 2022

@dxxyy I don't see it verified. If you are setup for verification, it's probably easiest to rebase/remove all your commits and start over with a new PR.

@dxxyy
Copy link
Contributor Author

dxxyy commented Mar 21, 2022

I did indeed the rebase and the merge commit lost the verification. I will close this and create a new one from scratch. Thanks

@dxxyy dxxyy closed this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants