Add support for clearing old certificates during reconnect #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottf
requested changes
Sep 4, 2024
| /// <param name="nkeySeedText">The text containing the "-----BEGIN USER NKEY SEED-----" block or the seed begining with "SU". | ||
| /// May be the same as the jwt string if they are chained.</param> | ||
| /// <param name="nkeySeedText">The text containing the "-----BEGIN USER NKEY SEED-----" block or the seed beginning with "SU". | ||
| /// Maybe the same as the jwt string if they are chained.</param> |
There was a problem hiding this comment.
"May be" was correct here. How about, "Both string can contain both the credentials and jwt block since they will be parsed for the required data."
There was a problem hiding this comment.
I did not have time to make this change according to your suggestion before this PR was merged.
Do you want me to make a new PR to fix this?
There was a problem hiding this comment.
sorry for the slow response, yeah, please fix when you get a chance. I'll make a release as soon as you do
There was a problem hiding this comment.
same here, sorry for the even slower response. Will make a new PR this week.
There was a problem hiding this comment.
PR is now created: #925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Optionsobject does not provide a way to remove once added certificates.This leads to that in case of certificate renewals the connection needs to be closed and recreated, including recreating all subscriptions. Just adding the new certificate and trying to reconnect with the old no longer relevant certificate and the new certificate in the certificate collection will make the connection fail on the TLS handshake.
Without a way to clear the certificates, reflection is required to get access to the internal
certificatesfield which can be problematic.By enabling library user to clear the certificates field through
ClearCertificates()and adding the new certificate, the connection can use the correct certificate during the next connection retry (if retrial is configured).This can be done for example in a user provided
ReconnectDelayHandlermethod.Other changes:
nameof()