Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging enhancements and improve error handling #570

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Jul 18, 2024

The commit refactors the error handling and logging within the NatsSvcServer and NatsSvcEndPoint classes. Updates have been made to the SvcListener, enhancing message logging and ensuring clean unsubscription on object disposal. The changes also facilitate better debugging and analysis by adding more logging statements for subscription handling within the SubscriptionManager class. Additional updates are made to handle possible errors in the handler loop within the NatsSvcEndPoint class.

The commit refactors the error handling and logging within the NatsSvcServer and NatsSvcEndPoint classes. Updates have been made to the SvcListener, enhancing message logging and ensuring clean unsubscription on object disposal. The changes also facilitate better debugging and analysis by adding more logging statements for subscription handling within the SubscriptionManager class. Additional updates are made to handle possible errors in the handler loop within the NatsSvcEndPoint class.
Copy link
Collaborator

@galvesribeiro galvesribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 509969a into main Jul 18, 2024
13 checks passed
@mtmk mtmk deleted the service-error-handling-fix branch July 18, 2024 17:23
mtmk added a commit that referenced this pull request Jul 18, 2024
* Add logging enhancements and improve error handling (#570)
* Base64 Encoding simplification + optimization (#549)
* Use string.Create when building a new inbox string (#551)
@mtmk mtmk mentioned this pull request Jul 18, 2024
mtmk added a commit that referenced this pull request Jul 18, 2024
* Add logging enhancements and improve error handling (#570)
* Base64 Encoding simplification + optimization (#549)
* Use string.Create when building a new inbox string (#551)
mtmk added a commit that referenced this pull request Aug 2, 2024
* Handle various protocol errors and socket exceptions (#584)
* Fetch idle timeout default fix (#582)
* Obj store empty list fixed (#578)
* KV never set duplicate window (#577)
* Resolved issue of ObjStore GetInfo MTime returning 0 (#567)
* Add logging enhancements and improve error handling (#570)
* Base64 Encoding simplification + optimization (#549)
* Use string.Create when building a new inbox string (#551)
@mtmk mtmk mentioned this pull request Aug 2, 2024
mtmk added a commit that referenced this pull request Aug 2, 2024
* Handle various protocol errors and socket exceptions (#584)
* Fetch idle timeout default fix (#582)
* Obj store empty list fixed (#578)
* KV never set duplicate window (#577)
* Resolved issue of ObjStore GetInfo MTime returning 0 (#567)
* Add logging enhancements and improve error handling (#570)
* Base64 Encoding simplification + optimization (#549)
* Use string.Create when building a new inbox string (#551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants