feat(kv): implement KeysWithFilters method for key filtering in KV bucket
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cket - Added KeysWithFilters method to KeyValue store to allow retrieving keys that match specific filters. - The method returns a list of keys from the KV bucket, applying the provided filters for pattern matching. - Checks consumer info to ensure filters are properly supported by the NATS server, with warnings for server versions < 2.10. Resolves: [nats-io#575](nats-io#575)
wallyqs
reviewed
Sep 4, 2024
wallyqs
reviewed
Sep 4, 2024
wallyqs
reviewed
Sep 4, 2024
wallyqs
requested changes
Sep 4, 2024
added 2 commits
September 4, 2024 20:21
- replace print with logger - added params to existing method keys() - add test file - update example - raise error
- replace print with logger - added params to existing method keys() - add test file - update example - raise error
|
thanks @wallyqs for the quick review, i have addressed the comments, please check once. |
wallyqs
reviewed
Sep 4, 2024
| try: | ||
| consumer_info = await watcher._sub.consumer_info() | ||
| if consumer_info and filters: | ||
| # If NATS server < 2.10, filters might be ignored. |
There was a problem hiding this comment.
there is a connected_server_version which can be used to check: https://github.com/nats-io/nats.py/blob/main/nats/aio/client.py#L1210C9-L1210C33
There was a problem hiding this comment.
this can't be invoked without an instance of nc I suppose?
I checked the usage of connected_server_version and this is how its been used
server_version = nc.connected_server_version
I believe creating an instance of nc won't be the best idea.
There was a problem hiding this comment.
think it is part of the state already here, maybe via self._js._nc
There was a problem hiding this comment.
no,
I have tried that already 😄
wallyqs
reviewed
Sep 4, 2024
- remove unnecessary logging line
somratdutta
changed the title
KeysWithFilters method for key filtering in KV bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #575