Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header name range validation #1031

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix header name range validation #1031

merged 1 commit into from
Jul 17, 2023

Conversation

caspervonb
Copy link
Collaborator

@caspervonb caspervonb commented Jul 17, 2023 •
edited
Loading

Closes #1030

@caspervonb caspervonb force-pushed the fix-header-name-validation branch from 6a1667f to 1cf1e6d Compare July 17, 2023 09:35
@caspervonb caspervonb requested a review from Jarema July 17, 2023 10:50
@caspervonb caspervonb force-pushed the fix-header-name-validation branch from 1cf1e6d to 81c69a6 Compare July 17, 2023 11:10
Jarema
Jarema approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit 08342bb into nats-io:main Jul 17, 2023
@Jarema Jarema mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alphanumeric enforcement on HeaderName breaks Implementation with Memphis.
2 participants
@caspervonb @Jarema