Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove memcpy in object store PUT #1039

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Remove memcpy in object store PUT #1039

merged 1 commit into from
Jul 18, 2023

Conversation

paolobarbolini
Copy link
Contributor

Removes a memcpy from the object store PUT implementation and a scary Box::new with a huge array

@paolobarbolini
Copy link
Contributor Author

Windows is hating us

caspervonb
caspervonb approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jarema Jarema merged commit b2e04d7 into nats-io:main Jul 18, 2023
@Jarema Jarema mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspervonb caspervonb caspervonb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolobarbolini @caspervonb @Jarema