Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AsRef for HeaderValue #1087

Merged
merged 3 commits into from
Aug 12, 2023

Conversation

caspervonb
Copy link
Collaborator

No description provided.

@caspervonb caspervonb requested a review from Jarema August 11, 2023 15:05
@caspervonb caspervonb changed the title Implement AsRef<[u]> for HeaderValue Implement AsRef<[u8]> for HeaderValue Aug 11, 2023
@caspervonb caspervonb force-pushed the implement-as-ref-for-header-value branch from e83f1e1 to 55da753 Compare August 11, 2023 15:06
@paolobarbolini
Copy link
Contributor

This could be done for &str too instead of having impl<'a> From<&'a HeaderValue> for &'a str 😃

@caspervonb caspervonb force-pushed the implement-as-ref-for-header-value branch from 55da753 to a2ba1e3 Compare August 11, 2023 17:54
@caspervonb caspervonb changed the title Implement AsRef<[u8]> for HeaderValue Implement AsRef for HeaderValue Aug 11, 2023
@caspervonb caspervonb force-pushed the implement-as-ref-for-header-value branch from 60687ed to b140740 Compare August 11, 2023 18:13
@caspervonb caspervonb force-pushed the implement-as-ref-for-header-value branch from 75bfb8c to 1dc000b Compare August 12, 2023 05:05
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema merged commit bfb8ea8 into nats-io:main Aug 12, 2023
@Jarema Jarema mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants