Add object store link #1091
Merged
Add object store link #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
add-object-store-link
branch
from
dac44be to
4cc97a3
Compare
| @@ -850,9 +1066,9 @@ fn is_default<T: Default + Eq>(t: &T) -> bool { | |||
| #[derive(Debug, Default, Clone, Serialize, Deserialize, Eq, PartialEq)] | |||
| pub struct ObjectLink { | |||
| /// Name of the object | |||
| pub name: String, | |||
| pub name: Option<String>, | |||
There was a problem hiding this comment.
Presumably this doesn't need to be Option<String> if it's already gated behind AddLinkErrorKind::EmptyName?
There was a problem hiding this comment.
It's still a valid case when adding a link to a bucket instead of object.
Until now, the subscription for reading Object data was spawn when calling `bucket.get()`. While that makes sense in many cases when implementing readers, it can lead to unwanted behaviours in NATS. The main issue being - there is no guarantee that user will start reading messages as soon as `bucket.get()` is called. That can lead to unnecesary idling subscription. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Before this change, users were forced to pass `info` field from `Object`. This is not very ergonomic, as what library needs to add link - a whole [Object], or just [ObjectInfo] should be internal. This change adds a trait that handles that. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
add-object-store-link
branch
from
4cc97a3 to
c56bbe7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek tomasz@nats.io