Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make object store structures more resilient #1127

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Oct 5, 2023

As some libraries might omit fields in structs when creating Object Store links, (as link and object have different always-filled fields, but they share the same schema) this change is to make it work with them.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema Jarema requested a review from piotrpio October 5, 2023 13:17
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema force-pushed the make-object-store-more-resilient branch from 79a8eaa to 4d28868 Compare October 5, 2023 13:27
@Jarema Jarema merged commit cee81b6 into main Oct 5, 2023
10 checks passed
@Jarema Jarema deleted the make-object-store-more-resilient branch October 5, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants