Make all BoxFutures 'static #1166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these futures are borrowing anything from outside their Box, so their lifetimes can be 'static. This avoids polluting a bunch of public types with unnecessary lifetime parameters.
Jarema
force-pushed
the
boxfuture-static
branch
from
ae78ff9
to
e912885
Compare
|
@oscarwcl this is good to be merged after solving the conflicts |
|
#1167 was based on this so this was already merged as part of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these futures are borrowing anything from outside their Box, so their lifetimes can be 'static. This avoids polluting a bunch of public types with unnecessary lifetime parameters.
Fixes #908