Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose BoxFuture in public API #1167

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Don't expose BoxFuture in public API #1167

merged 2 commits into from
Dec 17, 2023

Commits on Nov 30, 2023

  1. Make all BoxFutures 'static 

    None of these futures are borrowing anything from outside their Box, so
their lifetimes can be 'static. This avoids polluting a bunch of public
types with unnecessary lifetime parameters.
    @oscarwcl
    oscarwcl committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ae78ff9 View commit details
    Browse the repository at this point in the history

  2. Don't expose BoxFuture in public API 

    `ObjectStore::get` calls itself recursively, so the returned future
needs to be boxed. However, this is an implementation detail, there's no
reason to expose it in the public API. Instead, we can move the
recursive call to a separate `get_impl` function that handles the
boxing, and `get` can just be a standard async function.
    @oscarwcl
    oscarwcl committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    196437f View commit details
    Browse the repository at this point in the history