Preserve case of server error messages #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarwcl
force-pushed
the
preserve-error-case
branch
from
945ccba
to
17d6a26
Compare
caspervonb
reviewed
May 13, 2024
Server errors can contain case-sensitive values like subject names which can cause confusion if not displayed in their original case.
oscarwcl
force-pushed
the
preserve-error-case
branch
from
17d6a26
to
13fd1e8
Compare
Jarema
approved these changes
May 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server errors can contain case-sensitive values like subject names which can cause confusion if not displayed in their original case.
This was motivated by this error:
nats: permissions violation for publish to "$js.api.stream.info.kv_test", which is misleading since the actual subject is$JS.API.STREAM.INFO.KV_test.