Add stream_by_subject #1287
Merged
Add stream_by_subject #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
add-stream-by-name
branch
from
7d06700 to
139749d
Compare
Version 0.3.24 was causing error on minimal versions check: ``` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.24/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | help: consider giving `items` an explicit type, where the placeholders `_` are specified | 83 | let items: Box<_> = format_items | ++++++++ ``` Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
add-stream-by-name
branch
from
9ee8cd9 to
5a712b1
Compare
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to check if stream exist looking it up by subject was mentioned few times, recently here: vectordotdev/vector#20834
Signed-off-by: Tomasz Pietrek tomasz@nats.io