Add Websockets support #1330
Merged
Add Websockets support #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
add-ws-support
branch
from
4713596
to
5412416
Compare
caspervonb
reviewed
Oct 24, 2024
| pub(crate) struct WebSocketAdapter<T> { | ||
| #[pin] | ||
| pub(crate) inner: WebSocketStream<T>, | ||
| pub(crate) read_buf: BytesMut, |
There was a problem hiding this comment.
Why does it needs its own buffer?
There was a problem hiding this comment.
WS libraries returns whole WebSockets messages. Those can be way bigger than the ReadBuf. Is there a way to avoid that buffer easily? :)
There was a problem hiding this comment.
My bad, had to read the docs, it's a Stream, not a "Stream".
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
add-ws-support
branch
from
ed87c7e
to
81d3207
Compare
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
caspervonb
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass on Websockets support.
features:
what's missing:
next steps:
tokio_websocketsor add ability to choose betweentokio-websocketsandtokio-tungsteninte/fastwebsockets.Signed-off-by: Tomasz Pietrek tomasz@nats.io