Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sleep between connection attempts #407

Merged
merged 1 commit into from
May 3, 2022
Merged

Sleep between connection attempts #407

merged 1 commit into from
May 3, 2022

Conversation

caspervonb
Copy link
Collaborator

No description provided.

@caspervonb caspervonb requested a review from Jarema May 2, 2022 10:32
Jarema
Jarema requested changes May 2, 2022
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s make this a proper backoff.
Customizing and disabling it can be followed up with another PR though.

@caspervonb caspervonb force-pushed the sleep-between-reconnection-attempts branch from 75be0ff to 606f1c5 Compare May 3, 2022 08:18
@caspervonb caspervonb changed the title Sleep for a second between connection attempts Sleep between connection attempts May 3, 2022
@caspervonb caspervonb requested a review from Jarema May 3, 2022 08:20
Jarema
Jarema approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caspervonb caspervonb merged commit 2ededf1 into nats-io:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspervonb @Jarema