Add no responders #450
Merged
Add no responders #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
reviewed
May 24, 2022
caspervonb
reviewed
May 24, 2022
| @@ -1068,17 +1077,17 @@ pub struct Message { | |||
| pub reply: Option<String>, | |||
| pub payload: Bytes, | |||
| pub headers: Option<HeaderMap>, | |||
| status: Option<NonZeroU16>, | |||
| description: Option<String>, | |||
| } | |||
|
|
|||
| impl Message { | |||
| fn is_no_responders(&self) -> bool { | |||
There was a problem hiding this comment.
Put this an extension trait? or just make it a private helper fn in the scope you're gonna use it.
Suggested change
| fn is_no_responders(&self) -> bool { | |
| fn is_no_responders(&self) -> bool { |
There was a problem hiding this comment.
it is a private function now.
EDIT: extension trait would make sense if we we're making that available optionally to the users.
Jarema
force-pushed
the
jarema/no-responders
branch
from
53efce0
to
ad06081
Compare
Jarema
force-pushed
the
jarema/no-responders
branch
from
ad06081
to
a3c370c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.