Add JetStream types and basics #457
Conversation
async-nats/src/jetstream/types.rs
Outdated
| skip_serializing_if = "is_default" | ||
| )] | ||
| /// Indicates if rollups will be allowed or not. | ||
| pub allow_rollup: bool, |
There was a problem hiding this comment.
Do we wanna be explicit?
| pub allow_rollup: bool, | |
| pub allow_rollup_headers: bool, |
There was a problem hiding this comment.
No. I would stick to name describing behaviour.
async-nats/src/jetstream/mod.rs
Outdated
| @@ -15,6 +15,7 @@ use crate::Client; | |||
|
|
|||
| pub mod context; | |||
| pub mod response; | |||
| pub mod types; | |||
There was a problem hiding this comment.
Lets scope this to jetstream streams, we'll spot any duplication easily.
| pub mod types; | |
| pub mod stream; |
There was a problem hiding this comment.
I renamed the whole file. makes more sense.
| StreamConfig: From<S>, | ||
| { | ||
| let config: StreamConfig = stream_config.into(); | ||
| if config.name.is_empty() { |
There was a problem hiding this comment.
Lets ditch this check and add a test for it, ensure the server does still error.
| if config.name.is_empty() { |
There was a problem hiding this comment.
as found out, it returns no responders. Im still all for server-checks, but in this case... I would have this in.
async-nats/src/jetstream/context.rs
Outdated
| @@ -49,4 +54,25 @@ impl Context { | |||
|
|
|||
| Ok(response) | |||
| } | |||
|
|
|||
| pub async fn add_stream<S>(&mut self, stream_config: S) -> Result<StreamInfo, Error> | |||
There was a problem hiding this comment.
Add versus create? endpoint is create.
| pub async fn add_stream<S>(&mut self, stream_config: S) -> Result<StreamInfo, Error> | |
| pub async fn create_stream<S>(&mut self, stream_config: S) -> Result<StreamInfo, Error> |
There was a problem hiding this comment.
and all APIs are add.... hm.
Jarema
force-pushed
the
jarema/js-api
branch
3 times, most recently
from
9e23a74
to
e7f49cc
Compare
No description provided.