Introduce a StatusCode type to represent statuses
#474
Conversation
caspervonb
force-pushed
the
feat-status-code
branch
from
9760012
to
e67f2ca
Compare
|
|
||
| impl fmt::Display for InvalidStatusCode { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| f.write_str("invalid status code") |
There was a problem hiding this comment.
without knowing the actuall invalid status code user (and so we are) helpless here.
Why to store error code?
There was a problem hiding this comment.
Clamping to http status code range (100..1000) for sanity and easier from str parsing (only 3 digits to parse).
NATS server doesn't use the entire range (need to double check but think we're using 400-600 currently) but leaving us some room for expansions.
Also heavily borrowing/yanking from the http crate here.
I think you're wanting to store the code that was deemed invalid in the error?
There was a problem hiding this comment.
yeah, that was my idea, to store that code here.
There was a problem hiding this comment.
Would require two errors at-least (because of the conversion its coming from is either str or u16), so punting for now if you don't mind 😁 (Really should not happen in normal flow from server).
caspervonb
force-pushed
the
feat-status-code
branch
6 times, most recently
from
b819d3c
to
fdaf332
Compare
This introduces a `StatusCode` type modeled after HTTP status codes but adapted to known NATS constants.
caspervonb
force-pushed
the
feat-status-code
branch
from
fdaf332
to
db948ea
Compare
No description provided.