Allow tokens in connection strings and add tests #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
requested changes
Jun 16, 2022
There was a problem hiding this comment.
Hello there! thanks for the PR! with tests too, I like that 😁
Additions look good, some clippy and rustfmt errors.
One thing tho, even if we're pre 1.0 we try to minimize breaking changes and keep the nats crate stable. So we'd probably want to preserve has_user_pass and introduce something like has_token?
CC @Jarema
nats/src/connector.rs
Outdated
| @@ -603,9 +604,18 @@ impl ServerAddress { | |||
| self.0.scheme() == "tls" | |||
| } | |||
|
|
|||
| /// Returns if the server url had embedded username and password. | |||
| pub fn has_user_pass(&self) -> bool { | |||
There was a problem hiding this comment.
Public method, so probably don't want to be removing that outright.
There was a problem hiding this comment.
Agreed, I didn't mean to remove that. I've added it back.
|
@paulgb thanks for that PR! Now it IMHO looks good! |
Jarema
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many NATS clients allow for token authentication to be specified in a connection URL by passing a username without a password. This enables that approach, and adds some tests.
If this looks good, I'm happy to make a similar change on the
async_natsside, either in this PR or in a follow-up as appropriate.