Add streams to push consumers #527
Conversation
| } | ||
|
|
||
| impl futures::Stream for Stream { | ||
| type Item = Message; |
There was a problem hiding this comment.
Result<Message, Error>? that would mean tracking publish attempts in response to flow control etc
There was a problem hiding this comment.
I think that this can be answered as we discussed at client sync: we're aiming to report on any errors on specific consumers/subscriptions instead of silently passing by them or reporting them on registered callback.
So, Result<Message, Error> sounds better.
For sure we need that for Pull, and handling those errors differently (i.e. callback on Consumer) would make pretty inconsistent API for no good reason.
| } | ||
|
|
||
| impl futures::Stream for Stream { | ||
| type Item = Message; |
There was a problem hiding this comment.
I think that this can be answered as we discussed at client sync: we're aiming to report on any errors on specific consumers/subscriptions instead of silently passing by them or reporting them on registered callback.
So, Result<Message, Error> sounds better.
For sure we need that for Pull, and handling those errors differently (i.e. callback on Consumer) would make pretty inconsistent API for no good reason.
| continue; | ||
| } | ||
| Some(_) => { | ||
| continue; |
There was a problem hiding this comment.
are we sure that there are no other statuses we have to handle in any way? :)
There was a problem hiding this comment.
Fairly sure, should be at parity with sync at-least.
No description provided.