-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of ìnto_future` for requests and messages #782
Conversation
caspervonb
commented
Dec 23, 2022
•
edited
Loading
edited
- Makes Client::publish return an into_future based builder
- Makes Client::request return an into_future based builder.
- Makes Context::request return an into_future based builder.
- Makes Context::publish return an into_future based builder.
466bed0
to
e1a30bc
Compare
|
Having the |
Aye, inferring the type without boxing will help here. But it's still nightly. |
If they come out when you're in 1.0 though you'll have to make a breaking release. I could look into manually implementing the |
} | ||
|
||
impl Publish { | ||
pub fn new(sender: mpsc::Sender<Command>, subject: String, payload: Bytes) -> Publish { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not.
@caspervonb I would put it in queue for final review and merge after concrete errors for JetStream are merged, so we have only one conflict solving step. |
Quite a few conflicts in this one, closing in favor of #1003 |