Add concrete error types to JetStream #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema/jetstream-errors
branch
2 times, most recently
from
4b4d17a to
7714869
Compare
Jarema
force-pushed
the
jarema/jetstream-errors
branch
7 times, most recently
from
6b48665 to
bd17238
Compare
Jarema
changed the title
Jarema
force-pushed
the
jarema/jetstream-errors
branch
from
93f0db4 to
96b8f86
Compare
caspervonb
reviewed
Jun 14, 2023
| @@ -0,0 +1,476 @@ | |||
| // Copyright 2020-2022 The NATS Authors | |||
There was a problem hiding this comment.
This is all response related, maybe time for a response module?
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| #[derive(Debug, PartialEq, Eq, Clone, Copy, Deserialize, Serialize)] | ||
| pub struct ErrorCode(u64); |
There was a problem hiding this comment.
Move this into jetstream::response?
There was a problem hiding this comment.
as agreed, for now, made jetstream::error module not public ,and exposed Error and ErrorCode
|
|
||
| /// `Error` type returned from an API response when an error occurs. | ||
| #[derive(Debug, Serialize, Deserialize, Clone, PartialEq)] | ||
| pub struct Error { |
There was a problem hiding this comment.
Move this into jetstream::response?
async-nats/src/jetstream/mod.rs
Outdated
| @@ -132,6 +132,7 @@ use crate::Client; | |||
| pub mod account; | |||
| pub mod consumer; | |||
| pub mod context; | |||
| pub mod errors; | |||
There was a problem hiding this comment.
Think this module can be flattened into response (with into_future requests, we'll probably be having a request module too).
Suggested change
| pub mod errors; | |
| pub mod response; |
There was a problem hiding this comment.
Flattened as agreed on chat.
Error accessible via async_nats::jetstream::Error
Jarema
force-pushed
the
jarema/jetstream-errors
branch
2 times, most recently
from
ca07d72 to
6f9d4d4
Compare
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema/jetstream-errors
branch
from
6f9d4d4 to
cb3edc5
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: