Use MissedTickBehavior::Skip for flush interval
#880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervonb
changed the title
MissedTickBehavior::Burstfor ping and flush intervals
caspervonb
changed the title
MissedTickBehavior::Burstfor ping and flush intervalsMissedTickBehavior::Burst for ping and flush intervals
caspervonb
changed the title
MissedTickBehavior::Burst for ping and flush intervalsMissedTickBehavior::Skip for ping and flush intervals
Jarema
requested changes
Mar 16, 2023
There was a problem hiding this comment.
@caspervonb what do you think about ping?
I think Delay is better.
caspervonb
force-pushed
the
n1ghtmare/fix-tokio-intervals
branch
from
60c4316 to
7de7ab2
Compare
n1ghtmare
force-pushed
the
n1ghtmare/fix-tokio-intervals
branch
from
7de7ab2 to
f8f0875
Compare
n1ghtmare
changed the title
MissedTickBehavior::Skip for ping and flush intervalsMissedTickBehavior::Skip for flush interval
n1ghtmare
force-pushed
the
n1ghtmare/fix-tokio-intervals
branch
from
f8f0875 to
8b6df8d
Compare
n1ghtmare
force-pushed
the
n1ghtmare/fix-tokio-intervals
branch
from
8b6df8d to
20fd662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #875
As suggested by @caspervonb I'll split this into multiple PRs.