-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add const representation for standard header names #946
Add const representation for standard header names #946
Conversation
acf34e8
to
8540f61
Compare
8238589
to
56d6e04
Compare
3d1de1a
to
787ff29
Compare
787ff29
to
23248a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok, but I'm not happy about reintroducing unsafe
block.
Wondering if we can get rid of it.
Can't really get rid of it. It is safe tho, as the data is valid utf-8. |
@caspervonb I agree it's safe, but as some of our contributors mentioned, people run checks and disallow libraries with unsafe blocks. That's my concern. |
I'm not particularly worried about invariants that are known to be safe. Difference between just having to call an unsafe function to achieve an operation that is safe for a certain condition and being clever with unsafe hacks are quite different imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add const representation (an enum) for standard known header names.
Closes #945