Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty Leader #524

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Check for empty Leader #524

merged 1 commit into from
Aug 3, 2022

Conversation

tbeets
Copy link
Contributor

@tbeets tbeets commented Jul 7, 2022

For stream and consumer cluster step-down, check for empty leader before proceeding with step-down command.

In a case where there is no current leader (not a happy path case albeit), the CLI message is mis-formatted under this condition, e.g. Requesting leader step down of "" in a 4 peer RAFT group nats: error: JetStream system temporarily unavailable (10008), try --help (where it's actually an R3).

Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks, LGTM

@ripienaar ripienaar merged commit 57489cf into main Aug 3, 2022
@ripienaar ripienaar deleted the check-no-leader branch August 3, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants