Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made decode a little fast #55

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Made decode a little fast #55

merged 1 commit into from
Jul 3, 2023

Conversation

nanjj
Copy link
Contributor

@nanjj nanjj commented Jul 3, 2023

and added a benchmark test.

@coveralls
Copy link

coveralls commented Jul 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5442572719

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 79.732%
Totals Coverage Status
Change from base Build 5392021984: 0.3%
Covered Lines: 417
Relevant Lines: 523
💛 - Coveralls

@nanjj
Made decode a little fast
3018df5 
and added a benchmark test.

Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
derekcollison
derekcollison approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the contribution.

@derekcollison derekcollison merged commit 50e9b6d into nats-io:main Jul 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanjj @coveralls @derekcollison