Adding image build to workflow #198
Conversation
…ation. Signed-off-by: Samuel Attwood <sam@synadia.com>
| RUN apk add --no-cache ca-certificates | ||
|
|
||
| ARG BINARY=prometheus-nats-exporter | ||
|
|
||
| FROM scratch |
There was a problem hiding this comment.
Opinions on using gcr.io/distroless/static-debian11 here? That's essentially what we are making with scratch
There was a problem hiding this comment.
sounds good to me since that includes the certs
There was a problem hiding this comment.
there's benefit to using same distro - for example @philpennock tracks alpine security updates etc.
There was a problem hiding this comment.
I think the only things coming from debian in this image are CA Certificates and TZData. It has some other niceties, such as a /tmp directory and an /etc/passwd entry though.
There was a problem hiding this comment.
Clearly this particular image has been working fine without those things though, so fine to just leave it the way it is too
Signed-off-by: Samuel Attwood sam@synadia.com