chore: add time metrics to the exporter #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonberrutti
force-pushed
the
include-time-metrics
branch
from
e5227b4
to
b1a90b3
Compare
piotrpio
requested changes
Nov 7, 2023
| @@ -332,14 +338,6 @@ func (nc *NATSCollector) objectToMetrics(response map[string]interface{}, namesp | |||
| "gateway_tls_timeout": {}, | |||
| "gateway_connect_retries": {}, | |||
| } | |||
| labelKeys := map[string]struct{}{ | |||
There was a problem hiding this comment.
I'm not sure we want to gather metrics from all keys in varz. Other than the time-based metrics you want to add, this would include all the other strings from Varz struct, like go version, system account, http_base_path etc. I think we should leave labelKeys at they are and just add the required time metrics.
There was a problem hiding this comment.
You are right. I deleted it to test all the metrics and forgot to add it again.
ramonberrutti
force-pushed
the
include-time-metrics
branch
from
b1a90b3
to
b141887
Compare
piotrpio
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse time metrics as gauge