[FIX] Wait in the main goroutine #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpio
reviewed
Apr 3, 2024
main.go
Outdated
| @@ -92,6 +91,10 @@ func main() { | |||
| var retryInterval int | |||
| var printVersion bool | |||
|
|
|||
| // Setup the interrupt handler to gracefully exit. | |||
| c := make(chan os.Signal, 1) | |||
| signal.Notify(c, os.Interrupt) | |||
There was a problem hiding this comment.
I think we should handle more than just SIGINT here. Instead of os package (which does not have alias for SIGTERM), you could use signals from syscall:
signal.Notify(c, syscall.SIGINT, syscall.SIGTERM)I know that the old code just handled os.Interrupt but it would be nice to do it properly this time.
There was a problem hiding this comment.
I was curious whether to add SIGTERM, as it isn’t supported in Windows.
But I checked nats-server.
We can capture both signals.
Wait in the main routine for the interrupt signal instead of exiting the main routine. We are facing some crash when we try to gracefuly shoutdown the container. From the Official Documentation: Calling Goexit from the main goroutine terminates that goroutine without func main returning. Since func main has not returned, the program continues execution of other goroutines. If all other goroutines exit, the program crashes. https://pkg.go.dev/runtime#Goexit
ramonberrutti
force-pushed
the
no-exit-main-gorountine
branch
from
323df9e
to
48a4c14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait in the main routine for the interrupt signal instead of exiting the main routine. We are facing some crash when we try to gracefuly shoutdown the container.
From the Official Documentation:
Calling Goexit from the main goroutine terminates that goroutine without func main returning. Since func main has not returned, the program continues execution of other goroutines. If all other goroutines exit, the program crashes.
https://pkg.go.dev/runtime#Goexit