Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v0.12.x support #66

Closed
springmeyer opened this issue Oct 3, 2014 · 3 comments
Closed

Node v0.12.x support #66

springmeyer opened this issue Oct 3, 2014 · 3 comments

Comments

@springmeyer
Copy link
Collaborator

Ticket to discuss supporting node v.12.x.

Node v0.11.x hopefully will be released as node v.12.x at some point soon and brings serious API changes due to an upgrade in the v8 version included in node. Thank goodness https://github.com/rvagg/nan exists to smooth this transition. It will be a big effort but NAN would be ideal to start using soon. @kkoopa mentioned he has some scripts that can do auto-conversion as a first pass and I presume that is how he managed this amazing pull against node-mapnik: mapnik/node-mapnik#256.

@kkoopa
Copy link

kkoopa commented Oct 4, 2014

The regular expressions are located here: nodejs/nan#50
Note that they are partially outdated and cannot ever provide a fully automatic blind replace-all, as context-free languages are a superset of regular languages, but they are easy enough to adapt to any given project.

@brandonreavis
Copy link
Member

@kkoopa Thanks a bunch for those. They helped a lot!

The conversion was done here: 441dd54 with a few commits after that to fix up a few things.

@kkoopa
Copy link

kkoopa commented Nov 4, 2014

Cool. Being able to help out is always good. I copied the same information to the NAN wiki. If you have anything to add there, please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants