-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
41 port cvp mesh planner pkg to ros2 #46
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
04c1f8b
Update README.md
spuetz fc51723
Update README.md
spuetz c336d04
port pkg information to ROS2
Cakem1x 592c470
port includes and function signature to ROS2
Cakem1x 54279d9
refactor: add trailing underscore to class members
Cakem1x bff8ef2
change param declaration to fit ROS2
Cakem1x 60417cd
fix typo in docs
Cakem1x fff9871
change logging and reconfigure callback to work with ROS2
Cakem1x 89dadfa
change timing to use chrono; change msg types and publishing to fit ROS2
Cakem1x 0d676a9
change paramter names to be inside the plugin instance's namespace
Cakem1x bbcda49
refactor: revert accidental formatting
Cakem1x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,32 @@ | ||
cmake_minimum_required(VERSION 2.8.3) | ||
cmake_minimum_required(VERSION 3.8) | ||
project(cvp_mesh_planner) | ||
|
||
set(CMAKE_CXX_STANDARD 14) | ||
set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
set(CMAKE_CXX_EXTENSIONS OFF) | ||
find_package(ament_cmake_ros REQUIRED) | ||
find_package(mbf_mesh_core REQUIRED) | ||
find_package(mbf_msgs REQUIRED) | ||
find_package(mbf_utility REQUIRED) | ||
find_package(mesh_map REQUIRED) | ||
find_package(rclcpp REQUIRED) | ||
|
||
find_package(catkin REQUIRED COMPONENTS | ||
roscpp | ||
mbf_mesh_core | ||
mbf_utility | ||
mbf_msgs | ||
mesh_map | ||
dynamic_reconfigure | ||
) | ||
|
||
find_package(PkgConfig REQUIRED) | ||
pkg_check_modules(JSONCPP jsoncpp) | ||
|
||
generate_dynamic_reconfigure_options( | ||
cfg/CVPMeshPlanner.cfg | ||
) | ||
pluginlib_export_plugin_description_file(mbf_mesh_core cvp_mesh_planner.xml) | ||
|
||
catkin_package( | ||
LIBRARIES cvp_mesh_planner | ||
CATKIN_DEPENDS roscpp mbf_mesh_core mbf_utility mbf_msgs mesh_map dynamic_reconfigure | ||
) | ||
|
||
include_directories( | ||
include | ||
${catkin_INCLUDE_DIRS} | ||
) | ||
|
||
add_library(${PROJECT_NAME} | ||
src/cvp_mesh_planner.cpp | ||
) | ||
|
||
add_dependencies(${PROJECT_NAME} | ||
${${PROJECT_NAME}_EXPORTED_TARGETS} | ||
${catkin_EXPORTED_TARGETS} | ||
${PROJECT_NAME}_gencfg | ||
) | ||
|
||
target_link_libraries(${PROJECT_NAME} | ||
${catkin_LIBRARIES} | ||
${JSONCPP_LIBRARIES} | ||
) | ||
add_library(${PROJECT_NAME} src/cvp_mesh_planner.cpp) | ||
target_include_directories(${PROJECT_NAME} PUBLIC | ||
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> | ||
$<INSTALL_INTERFACE:include>) | ||
target_compile_definitions(${PROJECT_NAME} PRIVATE "CVP_MESH_PLANNER_BUILDING_LIBRARY") | ||
ament_target_dependencies(${PROJECT_NAME} mbf_mesh_core mbf_msgs mbf_utility mesh_map rclcpp) | ||
|
||
install(DIRECTORY include DESTINATION include) | ||
install(TARGETS ${PROJECT_NAME} | ||
ARCHIVE DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION} | ||
LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION} | ||
RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION} | ||
) | ||
|
||
install(FILES cvp_mesh_planner.xml | ||
DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION} | ||
EXPORT export_${PROJECT_NAME} | ||
ARCHIVE DESTINATION lib | ||
LIBRARY DESTINATION lib | ||
RUNTIME DESTINATION bin | ||
) | ||
|
||
ament_export_include_directories(include) | ||
ament_export_libraries(${PROJECT_NAME}) | ||
ament_export_targets(export_${PROJECT_NAME}) | ||
ament_export_dependencies(mbf_mesh_core mbf_msgs mbf_utility mesh_map rclcpp) | ||
ament_package() |
Empty file.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,19 @@ | ||
<?xml version="1.0"?> | ||
<package format="2"> | ||
<package format="3"> | ||
<name>cvp_mesh_planner</name> | ||
<version>1.0.1</version> | ||
<description>The Continuous Vector Field Planner (CVP) mesh planner package</description> | ||
<maintainer email="spuetz@uos.de">Sebastian Pütz</maintainer> | ||
<license>BSD 3-Clause</license> | ||
<author email="spuetz@uos.de">Sebastian Pütz</author> | ||
|
||
<buildtool_depend>catkin</buildtool_depend> | ||
|
||
<depend>roscpp</depend> | ||
<depend>rclcpp</depend> | ||
<depend>mbf_mesh_core</depend> | ||
<depend>mbf_utility</depend> | ||
<depend>mbf_msgs</depend> | ||
<depend>mesh_map</depend> | ||
<depend>dynamic_reconfigure</depend> | ||
|
||
<export> | ||
<mbf_mesh_core plugin="${prefix}/cvp_mesh_planner.xml"/> | ||
<build_type>ament_cmake</build_type> | ||
</export> | ||
</package> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this with member variables in the ftc_controller.
But i like this option, to use a struct member variable with all config options.
Maybe we can change it inside the ftc_controller and use this option for all mbf_plugins