Skip to content

Commit

Permalink
Add TODO comment explaining issue #323
Browse files Browse the repository at this point in the history
  • Loading branch information
corot committed Jul 27, 2023
1 parent 9c65437 commit d46ce9e
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ class AbstractActionBase
// if there is already a plugin running on the same slot, cancel it
slot_it->second.execution->cancel();

// TODO + WARNING: this will block the main thread for an arbitrary time during which we won't execute callbacks
if (slot_it->second.thread_ptr->joinable()) {
slot_it->second.thread_ptr->join();
}
Expand Down

0 comments on commit d46ce9e

Please sign in to comment.